search

boostorg / wave

Boost.org wave module
http://boost.org/libs/wave
21 stars 49 forks source link

Make updates for CMake version, dependencies, and C++ standard #190

Closed jefftrull closed 8 months ago

jefftrull commented 8 months ago

These issues were noted by @pdimov and the fix was to rerun boostdep --cmake (with a couple of manual changes for src/cpplexer files).

If merged this will resolve #189

pdimov commented 8 months ago

It's OK, but why reorder the source files? It just makes the diff more complicated for no good reason.

jefftrull commented 8 months ago

My thinking is that boostdep is now producing them in a different order, so by taking the reordering now we will have shorter diffs in the future.

I guess I could just always reorder them to match going forward instead. Hm... What do you think?

pdimov commented 8 months ago

The order in which the files are enumerated might be OS-dependent; on Windows, boostdep produces the same sorted list, but you are probably on Linux or Mac. Well, not that big of a deal, I suppose.