search

boostorg / wave

Boost.org wave module
http://boost.org/libs/wave
21 stars 49 forks source link

preprocess_pragma_output sample may be broken #90

Closed jefftrull closed 4 years ago

jefftrull commented 4 years ago

Clang gives a warning for this code, saying:

variable 'it' is incremented both in the loop header and in the loop body [-Wfor-loop-analysis]

which does seem to be the case. It's unclear whether that was by design and should probably be investigated.

jefftrull commented 4 years ago

@hkaiser AFAICT this second increment serves the function of skipping whitespace... does that seem right to you? If so I'll add a comment and a clang-tidy suppression.