search

boostorg / website-v2

New Boost website
https://preview.boost.org
Boost Software License 1.0
8 stars 8 forks source link

Version Dropdown Behavior #1096

Open vinniefalco opened 3 weeks ago

vinniefalco commented 3 weeks ago

The version dropdown which appears on the Libraries, Library, and Releases page should work thusly:

  1. All dropdowns show identical menu contents

  2. All dropdowns include master and develop

  3. When master or develop is chosen on the Releases page, instead of showing a release (which does not exist) we show an informational callout box explaining that there are no master or develop releases, along with a link to navigate them to the current release.

Consider moving master and develop to the bottom.

kennethreitz commented 3 weeks ago

We want master/develop at the bottom of the page too.

kennethreitz commented 3 weeks ago

The code is already written and merged to exclude master/develop in all three drop-downs (which all have separate code). This will get us to a good spot before launch.

Including custom ordering for the dropdrowns is extremely untrivial, unfortunately, due to the way Django is designed, so "simply including master/develop at the bottom of the list" is a surprisingly tall order. I tried about 45 different ways to do this, without any avail.

We can likely do it, but it's going to have to wait until after launch. We're in a good spot at the moment! re: #1080.

vinniefalco commented 3 weeks ago

Excluding master and develop from all the drop-downs is the next best thing, yes.

Just an aside, not actionable, but what do you think of putting an ascii 127 character at the beginning of the words "master" and "develop" so they sort to the bottom? :)

kennethreitz commented 3 weeks ago

That's a good solution! We can do that through the admin.