search

boostorg / website-v2

New Boost website
https://boost.io
Boost Software License 1.0
8 stars 13 forks source link

Make review views dynamic and add import script #1444

Closed GregKaleka closed 20 hours ago

GregKaleka commented 1 week ago

Probably needs some UI help. Also, should we drop the "submit review" page, or does that need to be functional? cc @rbbeeston

Screenshot 2024-11-13 at 4 40 22 PM Screenshot 2024-11-13 at 4 40 35 PM

rbbeeston commented 1 week ago

a couple of minor UI tweaks would clean it up considerably, lets go for something more like what we see on the releases page: Screenshot 2024-11-13 at 2 14 29 PM the title would be class="text-xl md:text-3xl" set left rather than center and wrap the charts in the "card" class

Also the avatars should be 36px by 36px.

Might look better to have a document icon and a github icon for the links.

rbbeeston commented 1 week ago

I'm not a fan of that sub-header either. Going to think on that a bit.

rbbeeston commented 1 week ago

After some thought, I feel like we should get rid of the subheader completely, and whatever links we are going to use to get to the page would be on one of the cards on the "Learn" page.

@vinniefalco I wasn't sure if they would make more sense in the "Contributor Guide" or "Formal Reviews" section. It would probably be goos to have a link to the release calendar in there as well, as it would be more intuitive to find there.

vinniefalco commented 1 week ago

Boost Mustard should not be used for pedestrian text

rbbeeston commented 1 week ago

yea, those status text should more be color coded based on success or failure, otherwise the standard text color.

GregKaleka commented 1 week ago

Improving...

Screenshot 2024-11-14 at 12 47 23 PM Screenshot 2024-11-14 at 12 47 34 PM

rbbeeston commented 1 week ago

that's much better

GregKaleka commented 1 week ago

Welp, I just went to see where I should add links on the Learn page, and I discovered we already have a separate page for this: https://www.boost.io/doc/formal-reviews/review-results.html. Thoughts on using this template vs the one I used during dev for this PR?

The large majority of the work I did for this is useful either way.

rbbeeston commented 1 week ago

I think overall what you put together looks better @vinniefalco do you have a preference?

GregKaleka commented 2 days ago

@rbbeeston I could use some help with the styling on the Review Process page (you can get there from the Learn tab). Specifically, the paragraph spacing is a bit wonky, a tags are not blue, and lists are not lists. Could you take a look and advise and/or push commits to this branch?

rbbeeston commented 2 days ago

I'll create a seperate ticket for the styling, this can get checked in once it's ready. Thanks!

GregKaleka commented 2 days ago

Cool, thanks Rob.

I'd love to have @daveoconnor look over the import script in particular.

GregKaleka commented 1 day ago

@daveoconnor thanks for the review - made changes per your suggestions. Please take a quick look when you can.

daveoconnor commented 1 day ago

@GregKaleka, looks good to me.