search

boostorg / winapi

Windows API declarations without <windows.h>, for internal Boost use.
63 stars 55 forks source link

Add Appveyor and Travis CI (if needed) #46

Closed jeking3 closed 7 years ago

jeking3 commented 7 years ago

We need a suite of tests that exercise the large number of compile-time branches in the project and ensure compatibility with Visual Studio versions (2010 through 2017) and older MinGW 32-bit and newer MinGW-x64.

jeking3 commented 7 years ago

@Lastique Please set milestone to v1.66.0 for this issue.

jeking3 commented 7 years ago

@Lastique I just noticed that my company email was used as the commit author instead of my apache.org email. It should be "jking@apache.org". Is there any way to fix that in the history, or is it impossible now that it was merged?

Lastique commented 7 years ago

It is possible to rewrite history on develop, but that will cause inconsistencies with the superproject (i.e. some commits in the superproject will be referring to a non-existent commit in Boost.WinAPI). Unless you really want to change that email (e.g. it might get you in trouble with your employer or something) I would prefer to avoid doing this. Please, let me know if you still want me to do this.

jeking3 commented 7 years ago

I figured it would be painful - we'll let it be.

On Tue, Sep 19, 2017 at 4:37 PM, Andrey Semashev notifications@github.com wrote:

It is possible to rewrite history on develop, but that will cause inconsistencies with the superproject (i.e. some commits in the superproject will be referring to a non-existent commit in Boost.WinAPI). Unless you really want to change that email (e.g. it might get you in trouble with your employer or something) I would prefer to avoid doing this. Please, let me know if you still want me to do this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/boostorg/winapi/issues/46#issuecomment-330666211, or mute the thread https://github.com/notifications/unsubscribe-auth/ALOdbZ8aXFQ-qXy14vlB6xD3vor7Evhuks5skCYhgaJpZM4PW6D9 .