search

boostorg / winapi

Windows API declarations without <windows.h>, for internal Boost use.
62 stars 58 forks source link

Fix issues found by new CI jobs: misalignments between Windows API and winapi #56

Closed jeking3 closed 6 years ago

jeking3 commented 6 years ago

Resolves incompatibilities with _WIN32_WINNT=0x0400 and 0x0A00 with the desktop family. 0x0501 was resolved with separate commits.

Results of Appveyor CI build: https://ci.appveyor.com/project/jeking3/winapi/build/1.0.22-develop Results of Travis CI build: https://travis-ci.org/jeking3/winapi/builds/276282135

This fixes #50 This fixes #52

Lastique commented 6 years ago

I've incorporated some of the fixes into develop.

jeking3 commented 6 years ago

I see that. I believe you've fixed #51. The changes in jobs.hpp will fix #50 and in config.hpp will fix #52.

jeking3 commented 6 years ago

@Lastique If you pull the jobs.hpp changes into develop, I'm not certain any of the config.hpp changes are needed (yet), however it would be nice to get these in if they result in a clean CI build (except for the non-desktop family job at the end, which is #53.

Lastique commented 6 years ago

I've pulled the fix for jobs.hpp to develop. We can focus on the non-desktop stuff now.

PS: The AppVeyor CI is not working currently for some reason, so I'll be fiddling with it trying to trigger with occasional commits. Sorry if that causes inconvenience.

jeking3 commented 6 years ago

I'm running my own CI builds by submitting a pull request into my own develop. :)

jeking3 commented 6 years ago

I'll submit a bcrypt.hpp pull request which may or may not include changes to config.hpp when I have something that works in random against it.