search

boostxyz / boost-protocol

A permissionless, trustless, and decentralized growth engine for protocol and application developers. It enables developers to bootstrap their projects by leveraging the power of community and the network effect.
https://boost-protocol.vercel.app
GNU General Public License v3.0
4 stars 2 forks source link

[BOOST-4736] fix(evm): enable multiple claims by an address for ERC1155Incentives #181

Closed topocount closed 1 day ago

topocount commented 2 days ago

Claimants can claim 1 ERC 1155 per transaction. Transactions are validated offchain, but to ensure a unique signanature and claim attempt, transaction hashes are passed in as part of the claim payload and stored onchain. As a basic validation with isClaimable, the same transaction hash cannot be claimed against, irrespective of the claim target

changeset-bot[bot] commented 2 days ago

⚠️ No Changeset found

Latest commit: f8828ef977d4744cc2afdebd22d2285f95940578

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

topocount commented 1 day ago

LGTM - of note we arn't emitting the tx hash so if that ends up being needed we'll need to add that but that's fine to handle separately and as needed.

@Quazia it's getting emitted here: https://github.com/boostxyz/boost-protocol/pull/181/files#diff-7326c8b2cb0d6f80be13943855ef79bdf1421fc4304b31801270da7aa3646d04R102