search

boostxyz / boost-protocol

A permissionless, trustless, and decentralized growth engine for protocol and application developers. It enables developers to bootstrap their projects by leveraging the power of community and the network effect.
https://boost-protocol.vercel.app
GNU General Public License v3.0
7 stars 3 forks source link

[ADHOC] fix(evm): ensure additional protocol fees can set fees per boost #244

Closed Quazia closed 1 week ago

Quazia commented 1 week ago

🚨 Please review the guidelines for contributing to this repository.

Description

Fix to account for per-boost protocol fees. Most likely we will not use this but better to have it and not need it etc. This PR will be passed off to the lead auditor as well.

💔 Thank you!

changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: 081df3125e41edd605e19038c2f885d4be98a919

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

sammccord commented 1 week ago
Fails
:no_entry_sign: Your PR body must reference a Github issue using a valid keyword, or your PR title must include the internal Boost ticket number, ie: `[BOOST-1234] Innovate like nuts`
Warnings
:warning: Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See [the publishing section of the README](https://github.com/boostxyz/boost-protocol?tab=readme-ov-file#changesets--publishing) for more info.

Generated by :no_entry_sign: dangerJS against f32d2abbe5eafbdb263fd0f701be922ca67c5c24

sammccord commented 1 week ago
Warnings
:warning: By using the `[ADHOC]` title prefix, you are bypassing best practice protections.
:warning: Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See [the publishing section of the README](https://github.com/boostxyz/boost-protocol?tab=readme-ov-file#changesets--publishing) for more info.

Generated by :no_entry_sign: dangerJS against 081df3125e41edd605e19038c2f885d4be98a919