Open pandeiro opened 8 years ago
Need more info. I have not seen this.
@pandeiro Are you still seeing this? I'm going to close this if there's no more info.
I'm seeing it too. Exception is:
java.lang.AssertionError: No ns form found in file:/home/wagjo/.boot/cache/tmp/home/proj/p3q/-x24pa9/adzerk/boot_cljs_repl.cljs
cljs.analyzer$parse_ns$fn__2009.invoke analyzer.cljc: 2751
cljs.analyzer$parse_ns.invokeStatic analyzer.cljc: 2706
cljs.analyzer$parse_ns.invoke analyzer.cljc: 2687
cljs.analyzer$parse_ns.invokeStatic analyzer.cljc: 2697
cljs.closure/find-cljs-dependencies/invokeStatic closure.clj: 691
cljs.closure/add-dependency-sources/invokeStatic closure.clj: 749
cljs.closure/build/invokeStatic closure.clj: 1892
cljs.build.api/build/invokeStatic api.clj: 206
adzerk.boot-cljs.impl/compile-cljs/invokeStatic impl.clj: 76
adzerk.boot-cljs.impl/compile-cljs impl.clj: 66
...
clojure.core/apply/invokeStatic core.clj: 646
clojure.core/apply core.clj: 641
boot.pod/eval-fn-call pod.clj: 294
boot.pod/call-in* pod.clj: 315
...
boot.pod/call-in* pod.clj: 318
adzerk.boot-cljs/compile boot_cljs.clj: 71
adzerk.boot-cljs/compile-1/fn boot_cljs.clj: 126
clojure.core/binding-conveyor-fn/fn core.clj: 1916
Dependencies
[adzerk/boot-cljs "1.7.228-1" :scope "test"]
[adzerk/boot-cljs-repl "0.3.0" :scope "test"]
[adzerk/boot-reload "0.4.4" :scope "test"]
task we're running
(comp
(system :sys #'foo.standalone/system :auto-start true)
(watch)
(less :source-map true :compression false :inline-javascript true)
(reload :on-jsload 'foo.app/fig-reload)
(cljs-repl)
(cljs :source-map true))
@Deraen This issue still exists for us; its infrequency means it's not a big deal, but we still get failed tests now and then because of it. And now it has been seen by @wagjo as well. Not sure what should / can be done, but if there's something else I can do, please let me know.
I'm yet to see this myself.
A start would be to have a test project where you can reproduce this so that I could try to reproduce this.
@wagjo Are you able to reproduce this reliably? How frequently do you see this? It would be great if we could create a sample repo for Juho to look at.
Nope, I only get this error in about 5% of runs.
I think I might be getting the same bug - on Travis CI sometimes the build fails after successful run, even if nothing changed. E.g. https://travis-ci.org/mjmeintjes/boot-react-native/builds/109811514 vs https://travis-ci.org/mjmeintjes/boot-react-native/builds/109810642 (same source code, just merged branch).
I think there is a chance that recent change in Boot-reload 0.5.0 might have fixed this: https://github.com/adzerk-oss/boot-reload/commit/9f430b2aa9acd06d45ae7e72ade569fb178a6c21
I have not seen this myself in 5 months and I don't recall anyone at work mentioning this since the change, so I'll presume this was fixed.
Except Boot-cljs-repl still uses the old way to inject code to the build: https://github.com/adzerk-oss/boot-cljs-repl/blob/master/src/adzerk/boot_cljs_repl.clj#L168
A very rare (maybe 5% or less of the time) bug I am hitting when using boot-cljs, boot-reload and multiple
cljs.edn
builds is the "No ns form found ...". It appears that the file that boot-reload is injecting prior to cljs compilation is empty when the(cljs ...)
task tries to compile it:Could this be related to some race condition with the
cljs
task? The low reproducibility suggests something like that to me, prior to going into theimpl.cljs
and inspecting.