boot-clj / boot-cljs

Boot task to compile ClojureScript programs.
Eclipse Public License 1.0
176 stars 40 forks source link

jdk7 broken on 2.0.0 due to no java.util.Base64 #161

Closed kentfredric closed 7 years ago

kentfredric commented 7 years ago

Commit af670d3acff6990b7ba256d7ae0d12b82b744948 breaks support for JDK7 by relying on java.util.Base64

Retrieving boot-cljs-2.0.0.pom from https://repo.clojars.org/ (2k)
Retrieving boot-cljs-2.0.0.jar from https://repo.clojars.org/ (12k)
                                                  Boot.main                         Boot.java:  258
                                                        ...                                        
                                              boot.App.main                          App.java:  491
                                           boot.App.runBoot                          App.java:  399
org.projectodd.shimdandy.impl.ClojureRuntimeShimImpl.invoke       ClojureRuntimeShimImpl.java:  150
org.projectodd.shimdandy.impl.ClojureRuntimeShimImpl.invoke       ClojureRuntimeShimImpl.java:  159
                                                        ...                                        
                                            boot.main/-main                          main.clj:  206
                                         boot.main/-main/fn                          main.clj:  206
                                                        ...                                        
                                           boot.user/eval34  boot.user3880572273587290059.clj:    7
                                                        ...                                        
                                       clojure.core/require                          core.clj: 5911 (repeats 2 times)
                                         clojure.core/apply                          core.clj:  659
                                                        ...                                        
                                     clojure.core/load-libs                          core.clj: 5873
                                     clojure.core/load-libs                          core.clj: 5889
                                         clojure.core/apply                          core.clj:  659
                                                        ...                                        
                                      clojure.core/load-lib                          core.clj: 5832
                                      clojure.core/load-lib                          core.clj: 5851
                                   clojure.core/load-lib/fn                          core.clj: 5852
                                      clojure.core/load-one                          core.clj: 5812
                                                        ...                                        
                                          clojure.core/load                          core.clj: 5991
                                          clojure.core/load                          core.clj: 6007
                                       clojure.core/load/fn                          core.clj: 6008
                                                        ...                                        
                                    adzerk.boot-cljs/eval40                     boot_cljs.clj:    1
                    adzerk.boot-cljs/eval40/loading--auto--                     boot_cljs.clj:    1
                                                        ...                                        
                                       clojure.core/require                          core.clj: 5911 (repeats 2 times)
                                         clojure.core/apply                          core.clj:  659
                                                        ...                                        
                                     clojure.core/load-libs                          core.clj: 5873
                                     clojure.core/load-libs                          core.clj: 5889
                                         clojure.core/apply                          core.clj:  659
                                                        ...                                        
                                      clojure.core/load-lib                          core.clj: 5832
                                      clojure.core/load-lib                          core.clj: 5851
                                   clojure.core/load-lib/fn                          core.clj: 5852
                                      clojure.core/load-one                          core.clj: 5812
                                                        ...                                        
                                          clojure.core/load                          core.clj: 5991
                                          clojure.core/load                          core.clj: 6007
                                       clojure.core/load/fn                          core.clj: 6008
                                                        ...                                        
                         adzerk.boot-cljs.middleware/eval65                    middleware.clj:    1
         adzerk.boot-cljs.middleware/eval65/loading--auto--                    middleware.clj:    1
                                                        ...                                        
                                       clojure.core/require                          core.clj: 5911 (repeats 2 times)
                                         clojure.core/apply                          core.clj:  659
                                                        ...                                        
                                     clojure.core/load-libs                          core.clj: 5873
                                     clojure.core/load-libs                          core.clj: 5889
                                         clojure.core/apply                          core.clj:  659
                                                        ...                                        
                                      clojure.core/load-lib                          core.clj: 5832
                                      clojure.core/load-lib                          core.clj: 5851
                                   clojure.core/load-lib/fn                          core.clj: 5852
                                      clojure.core/load-one                          core.clj: 5812
                                                        ...                                        
                                          clojure.core/load                          core.clj: 5991
                                          clojure.core/load                          core.clj: 6007
                                       clojure.core/load/fn                          core.clj: 6008
                                                        ...                                        
                               adzerk.boot-cljs.util/eval71                          util.clj:    1
               adzerk.boot-cljs.util/eval71/loading--auto--                          util.clj:    1
                                                        ...                                        
                                    java.lang.Class.forName                        Class.java:  278
                                   java.lang.Class.forName0                         Class.java     
                            java.lang.ClassLoader.loadClass                  ClassLoader.java:  358
                                                        ...                                        
                            java.lang.ClassLoader.loadClass                  ClassLoader.java:  425
                                                        ...                                        
                          java.net.URLClassLoader.findClass               URLClassLoader.java:  347
                java.security.AccessController.doPrivileged              AccessController.java     
                              java.net.URLClassLoader$1.run               URLClassLoader.java:  348
                              java.net.URLClassLoader$1.run               URLClassLoader.java:  359
java.lang.ClassNotFoundException: java.util.Base64
      clojure.lang.ExceptionInfo: java.util.Base64
    file: "adzerk/boot_cljs/util.clj"
    line: 1
Deraen commented 7 years ago

Hmm, I guess I can find a solution for this.

But I'd strongly recommend using Java 8, in my experience removal of PermGen memory in Java 8 helps a lot with Boot memory usage.