search

boot-clj / boot-cljs

Boot task to compile ClojureScript programs.
Eclipse Public License 1.0
176 stars 40 forks source link

Wrap :main value in symbol #165

Closed arichiardi closed 7 years ago

arichiardi commented 7 years ago

This avoids triggering a ClassCastException when trying to use values from the requires sorted set: string :main is a valid value and will always be converted.

DonyorM commented 7 years ago

Until this commit is merged, is there anyway to specify a :main value? Specifying a symbol directly seems to cause other errors.

arichiardi commented 7 years ago

Try a symbol with no tick, Juho will merge this soon I think.

DonyorM commented 7 years ago

That didn't work either. Well I guess I'll wait till this get merged.

DonyorM commented 7 years ago

I'm porting the luminus template to Boot, but I need this fix in place in order for it to work the same as the lein template does. Since I know it can be some time between merge and release to clojars, would it be possible to get this merged, so I can at least tell people to install from the master branch for testing, rather than a PR?

Deraen commented 7 years ago

Merged and released. Btw. I've been using symbol value, that definitely works even without this change. Also, this wasn't a problem with previous versions as support for :main option was added in this release.

DonyorM commented 7 years ago

Thanks for the quick response!

I did try using a symbol, maybe I had a different issue and blamed it on the :main value (cljs docs say to just use strings, so I assumed anything else wasn't supported). In that case, sorry to be a pest.