Open freakinruben opened 7 years ago
Thanks for the report, yes that does not look right at all. I am not familiar with hoplon
at all but if you have a minimal repro repo, or want to use a branch in this repo I can have a look.
Also I see you haven't posted any .cljs.edn
file here, just want to point out that it is mandatory for boot-figreload
(and in general is good to have it for that matter).
I'm not super familiar with Hoplon myself, but here is the repo cloned and adjusted (to my best knowledge) for hoplon. Weather or not the hoplon part is correct, running boot dev
will give the same error as I have with my own code.
About the .cljs.edn
file, hoplon generates this for you. The generated edn before figreload with the repo above is:
{:require [figreload-demo.index adzerk.boot-cljs-repl]}
After:
{:require [figreload-demo.index figwheel.connect./Users/foo/.boot/cache/tmp/Users/foo/Projects/figreload-demo/6h7/-7bl902/index.html.cljs.edn-72fbe00c adzerk.boot-cljs-repl]}
Ok that is great thanks, I will have a look.
It looks like hoplon is creating a .cljs.edn
file that fails my regex here...I don't have much time now, but a patch should be really trivial, I am basically taking the build-id
, the part before cljs.edn
which in your case above is index.html
but really should be index
.
I replaced the (\w+) with ([a-zA-Z0-9_.]+) and even tho at the REPL, when given "index.html.cljs.edn" it returns "index.html" it still give the error.
I also changed it to ([a-zA-Z0-9_]+).(.+) which only returns "index" and no improvement.
I'd like to start using this ASAP. Any more ideas?
@vigilancetech-com what error do you get? Same as above? It's been a while but I though the regex would solve.
Not sure weather this is an issue of hoplon or boot-figreload but since the invalid string in the
index.html.edn.cljs
is added by boot-figreload I assume it belongs here.I'm trying to use hoplon with boot-figreload. Hoplon generated an .cljs.edn file which normally lookes something like:
Now, with boot-figreload a long invalid namespace is added to the edn:
Resulting in an error when I try to compile the cljs:
Snipped from
build.boot
: