search

boot-clj / boot-figreload

Boot task providing live-reload using Fighweel client
Eclipse Public License 1.0
49 stars 1 forks source link

configuration conflict with boot-cljs #3

Closed leroix closed 7 years ago

leroix commented 7 years ago

To set the path prefix for files output by boot-cljs, they recommend storing the .cljs.edn file in the path where you'd like the files to be output. boot-figreload names the figwheel.connect... namespace according to the :id. If I store the .cljs.edn file at js/dev.cljs.edn, the figwheel namespace becomes figwheel.connect.js/dev. This causes a compilation error.

mbuczko commented 7 years ago

to be precise compilation error look like this:

No such namespace: figwheel.connect.scripts/main,  could not locate
figwheel/connect/scripts_SLASH_main.cljs, figwheel/connect/scripts_SLASH_main.cljc,
or Closure namespace "main" in file boot/cljs/main31906.cljs

for main.cljs.edn in scripts/ dir

arichiardi commented 7 years ago

Thanks for reporting, I will check what is going on.

arichiardi commented 7 years ago

Good ol' bug here, I'll fix it asap

arichiardi commented 7 years ago

So figwheel does not have the concept of configuration in different folders, which means that the build id will always be the name of the file with extension .cljs.edn. I am correcting the problem.

arichiardi commented 7 years ago

If you folks can confirm it is fixed it would be awesome, I have a repro repo here where it seems to be ok.

mbuczko commented 7 years ago

works perfectly. thanks for your time on fixing this issue. looks like boot-figreload became better than figwheel itself :)

arichiardi commented 7 years ago

Oh well, thanks for the support, but I think there is still a lot to do :1st_place_medal: