boot-clj / boot-new

Generate new projects based on Boot Templates and/or Leiningen Templates!
https://clojars.org/boot/new
Eclipse Public License 1.0
155 stars 42 forks source link

Add `resources/.keep` (or remove resources/ folder?) #30

Closed HakimCassimallyBBC closed 7 years ago

HakimCassimallyBBC commented 7 years ago

By default, boot-new creates a resources/ folder with no contents, referenced from build.boot.

This means that e.g. git won't add the folder, so on next checkout, your boot build will fail with a confusing error message (which you likely won't understand, as you're using boot-new ;-)

We've worked around this by adding a resources/.keep file, but I believe we could simply have removed the directory from the build.boot instead. Either way, the process would be made less confusing for new boot users.

seancorfield commented 7 years ago

Sounds like a good enhancement (to add an empty dot file).

seancorfield commented 7 years ago

Fixed in 0.5.1 which I just released to clojars.org.

HakimCassimallyBBC commented 7 years ago

Wonderful, thanks @seancorfield!

DjebbZ commented 7 years ago

For me it's not solved : .keep is an empty folder, not an empty file... So same problem, as git doesn't track empty folders.

Executed just now :

$ boot -d boot/new new -t default -n foobar
# some output...
$ ls -la foobar/resources/
drwxr-xr-x 3 djebbz djebbz 4.0K Sep 29 16:22 ./
drwxr-xr-x 6 djebbz djebbz 4.0K Sep 29 16:22 ../
drwxr-xr-x 2 djebbz djebbz 4.0K Sep 29 16:22 .keep/