search

boot-clj / boot

Build tooling for Clojure.
https://boot-clj.github.io/
Eclipse Public License 1.0
1.75k stars 182 forks source link

Ability to pass more options to REPLy #113

Open piranha opened 9 years ago

piranha commented 9 years ago

Reason for that is whidbey, which needs to pass :nrepl-context to REPLy to work correctly. Here is the link to IRC chat discussing this problem. It's desirable to have some way of doing that from .profile.boot. :)

piranha commented 9 years ago

I've tried converting boot.repl-client/default-opts in atom, but that's not very useful - I can't refer it from .profile.boot anyway. Plus to actually make whidbey work I have to pass whidbey.render/render-str as an argument there, and I can't (require 'whidbey.render) in .profile.boot as well.

I'm a bit lost on how to approach this.

micha commented 9 years ago

Can you explain the :nrepl-context situation please? Boot is running reply in standalone mode, i.e. reply isn't starting the nrepl server, and I don't see a :nrepl-context option to pass to reply.main/launch-nrepl.

piranha commented 9 years ago

In reply :nrepl-context is used here. Give me few moments to see where it's called from.

micha commented 9 years ago

Does it work in standalone mode? (That is to say, connecting to an already running nrepl server?)

piranha commented 9 years ago

Aha, here options are passed from reply.eval-modes.nrepl/main to execute-with-client.

piranha commented 9 years ago

I'm not sure, but guessing from the code - it should, right?