search

boot-clj / boot

Build tooling for Clojure.
https://boot-clj.github.io/
Eclipse Public License 1.0
1.75k stars 180 forks source link

Report changed files even when md5 is the same #569

Closed arichiardi closed 7 years ago

arichiardi commented 7 years ago

I am debugging a case in boot-figreload where I am logging the following on the fileset:

(butil/warn "Changed %s\n" (butil/pp-str (map (juxt :path :hash) (b/ls (b/fileset-diff @prev-pre fileset :hash)))))

The output of different runs is:

#1: Changed (["rest_resources_viz/core.cljs" "2015aeab1a260d66ad4d6390e47d44f8"]
             ["main.cljs.edn" "347945304e5da6f54c81696e76746ad0"])
#2: Changed (["rest_resources_viz/core.cljs" "f77a8ad945fabd087807d2ea4e788814"]
             ["main.cljs.edn" "347945304e5da6f54c81696e76746ad0"])
#3: Changed (["rest_resources_viz/core.cljs" "7f1662dd948112c61e6f21bb045c9d2c"]
             ["main.cljs.edn" "347945304e5da6f54c81696e76746ad0"])

Note that the file names are not there on purpose and :hash is passed to the function. The second one is reported as changed while it is not it seems.

This issue occurs with fileset-changed as well. Can it be related to #566?

arichiardi commented 7 years ago

Closing, the problem was elsewhere. :upside_down_face: