boot-clj / boot

Build tooling for Clojure.
https://boot-clj.github.io/
Eclipse Public License 1.0
1.75k stars 180 forks source link

aot should throw exception if no param #573

Closed mobileink closed 7 years ago

mobileink commented 7 years ago

The aot task requires one of --all or --namespace. If neither is provided, either an exception should be thrown or a prominent warning message should be emitted.

esanmiguelc commented 7 years ago

This one seems simple enough, I can take a stab at it.

I'm thinking that it should be a warning; something along the lines of "aot will not be run - here's what you should do". Would it make sense for the task to actually just default to --all?

mobileink commented 7 years ago

I'm inclined to think there should be no default. If the user does not specify what is to be aot-compiled, the task should fail. to avoid surprises.

alandipert commented 7 years ago

Closing in favor of #576 where discussion can continue.