boot-clj / boot

Build tooling for Clojure.
https://boot-clj.github.io/
Eclipse Public License 1.0
1.75k stars 180 forks source link

With-cp does not consider source/resource paths #596

Closed arichiardi closed 7 years ago

arichiardi commented 7 years ago

Probably a very easy fix on this line.

Reminder 😁

hit023 commented 7 years ago

Newcomer here: @alandipert and @arichiardi , can I get some idea on what is wrong and how should the fix look like ?

arichiardi commented 7 years ago

Basically at the moment the code builds a string with resolved entries from the : dependencies, it should append also the stings contained in :source-paths, @alandipert can tell us if asset-paths is also necessary here 😀

hit023 commented 7 years ago

(apply str (interpose ":" relative-paths) (interpose ":" (into [ ] :source-paths))) Am I on the right track? I'm not really sure if :source-paths can be used like this.

arichiardi commented 7 years ago

@hit023 you are on the right track, you just need to grab source-path in a let binding before the line you posted (where you used it).