search

boot-clj / boot

Build tooling for Clojure.
https://boot-clj.github.io/
Eclipse Public License 1.0
1.75k stars 182 forks source link

Fixes #555 and #596 #600

Closed hit023 closed 7 years ago

arichiardi commented 7 years ago

Good job 😀 I left a couple of notes and I would suggest to implement some tests around the new features. Also running the previously existing test is a way to confirm you did not break anything (run make clean test).

arichiardi commented 7 years ago

@hit023 we can refactor this to solve #596 only and keep a separate one for the other, what do you think? Also, can I help with something here?

hit023 commented 7 years ago

Yes, @arichiardi . I'd love to get on with work, here. But my end-semester exams are underway, so I can resume only afterwards. Thanks.

arichiardi commented 7 years ago

@hit023 Closing this in favor of #611 and #608