Fixes #617: Add simple template processor in `jar :file`.

[jgrzebyta]

• accepts version and project templates

Signed-off-by: Jacek Grzebyta jgrzebyta@users.noreply.github.com

[Deraen]

Lein uses format for these, and only supports using version: :jar-name "hello-%.jar". Maven supports properties: <file>foo-${foo.version}</file>.

I think copying Lein behaviour would be sensible, unless there is a good reason to also support project name?

[jgrzebyta]

What about making separate - uberised - jar? In maven user might compile normal jar or the executable '-with-dependencies' one. Does your solution require having separate build file with different project name?

Best regards, Jacek

On 26 Sep 2017 6:23 p.m., "Juho Teperi" notifications@github.com wrote:

Lein uses format for these, and only supports using version: :jar-name "hello-%.jar". Maven supports properties: foo-${foo.version}.

I think copying Lein behaviour would be sensible, unless there is a good reason to also support project name?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/boot-clj/boot/pull/618#issuecomment-332272414, or mute the thread https://github.com/notifications/unsubscribe-auth/AGbRXBn13C6t0t-2gj4-YODz5xPOKk2Qks5smTMJgaJpZM4N8SXe .

[alandipert]

I think we're not really comparable to either lein or maven in this case, since we're programmable. The user can easily fill a template string in their build.boot based on strings they define and pass as arguments to tasks, which could also be the strings used to generate the pom.

That said, I see no reason not to do this, even if its arguably going against the grain in our model. It's backward compatible and can save some typing. :+1:

@Deraen if you are OK with it too please feel free to merge when you see this.

[martinklepsch]

@jgrzebyta are you planning to get back to this or should it be closed? 🙂

[jgrzebyta]

@martinklepsch I will close this PR.

[martinklepsch]

Ok! Thanks for your efforts! 💛