search

boot-clj / boot

Build tooling for Clojure.
https://boot-clj.github.io/
Eclipse Public License 1.0
1.75k stars 180 forks source link

Boot does not sign jars with classifiers #623

Closed arichiardi closed 6 years ago

arichiardi commented 7 years ago

Boot Bug Report

Platform details

Platform: Linux

Platform version:

openjdk version "1.8.0_131"
OpenJDK Runtime Environment (build 1.8.0_131-8u131-b11-0ubuntu1.16.04.2-b11)
OpenJDK 64-Bit Server VM (build 25.131-b11, mixed mode)

Boot details

Boot version: master build.boot present? (yes/no): yes ~/.boot/profile present? (yes/no): no Task name? (if applicable): push

build.boot content (if applicable)

;; build.boot content here

~/.boot/profile content (if applicable)

... push {:pom (str extractor-project)
               gpg-sign true
               ...
              }

Description

The gpg signature produces wrong output file names for artifacts with the :classifier tag in their coordinates, which might be present if the deployed jar is of the -sources or -javadoc kind.

Steps to reproduce

Just try to boot push --gpg-sign three files main-0.1.0.jar, main-0.1.0-sources.jar and main-0.1.0-javadoc.jar. The only generated .asc file will be main-0.1.0.jar.asc.

The bug seems in https://github.com/boot-clj/boot/blob/ac835cea8c18e926bb843e01579b86e3f30458d2/boot/pod/src/boot/gpg.clj#L52 which does not consider :classifier. Will debug later.