search

boot-clj / boot

Build tooling for Clojure.
https://boot-clj.github.io/
Eclipse Public License 1.0
1.75k stars 180 forks source link

Color disabling flags seem to be ignored on Windows 10 #660

Open mudgen opened 6 years ago

mudgen commented 6 years ago

Platform details

Platform (macOS, Linux, Windows): Windows 10 Platform version: JRE/JDK version (java -version): 64-Bit Server VM 1.8.0_60-b27

Boot details

(boBoot version (2.7.1): 2.7.2 build.boot present? (yes/no): yes ~/.boot/profile present? (yes/no): no Task name? (if applicable): build

Description

Steps to reproduce

I executed the following in a boot repl:

boot.user=> (boot (build)) ?[1mWriting pom.xml and pom.properties... ?[m?[1mWriting ignition-project-1.0.0.jar... ?[m?[1mInstalling ignition-project-1.0.0.jar... ?[mnil

See the strange ?[m? characters?

alandipert commented 6 years ago

I think those are terminal color codes unsupported by your terminal. Guessing running boot with boot -C should fix.

mudgen commented 6 years ago

Thanks for checking it out. I tried boot -C repl -C and then tried running (boot (build)). I got the same output.

But I think you are right, that it is terminal color codes unsupported by my terminal. It seems that the -C option is not working.

This problem may be related to issue: #647

mudgen commented 6 years ago

Can boot detect that my terminal does not support color codes and automatically not use them?

mudgen commented 6 years ago

I would really like to see this issue fixed.

mudgen commented 6 years ago

The color codes only show when executing commands with the REPL. The color codes do not show when using boot on the command line. Can boot be fixed so that when color is turned off the REPL does not show the color codes? Or something?

martinklepsch commented 6 years ago

Hey, can you check the value of

(deref boot.util/*colorize?*)

Ideally check for the value when you start Boot using boot -C repl and boot -C repl -C.

mudgen commented 6 years ago

Hi @martinklepsch, I will check the value of (deref boot.util/colorize?) later when I have time.

On Windows 10 only boot -C works. The -C option does not currently work for the repl task. It is broken. boot -C repland boot -C repl -C do not do anything on Windows 10 command line. I would really like for this to be fixed because currently I have tons of color code gook in my repl.

mudgen commented 6 years ago

@martinklepsch I executed (deref boot.util/*colorize?*) and the value is false