search

boot-clj / boot

Build tooling for Clojure.
https://boot-clj.github.io/
Eclipse Public License 1.0
1.75k stars 181 forks source link

Parse complex optargs with sequential types #682

Closed arichiardi closed 6 years ago

arichiardi commented 6 years ago

This patch enables to parse options using complex optargs like SYM:VER=PATH with types that are not nested but straight up sequential, like [sym str str].

arichiardi commented 6 years ago

Don't understand why the tests are failing in this very weird way:

FAIL in boot.cli-test/cli-tests (cli_test.clj:43)                               
parse-cli
[fix #578] split arguments with two different separators using vector optarg.
expected: {:parent [prj "1.3" "parent"]}
  actual: {:parent [ prj "1.3" "parent"]}
    diff: - {:parent [prj]}
          + {:parent [ prj]}

What is the space there I can't understand, but I will :+1:

martinklepsch commented 6 years ago

Merged https://github.com/boot-clj/boot/commit/197f991324d9207f5d4b7b1828dd54ff61aadd09 https://github.com/boot-clj/boot/commit/69e2957c05023b312296f4f8940ed88b78ebaa59 https://github.com/boot-clj/boot/commit/9b21dd98d18c96d856250c0b7555b8a660f7704e

martinklepsch commented 6 years ago

I need to revisit my workflow for merging PRs bit annoyed that this is picked up as closed instead of merged now. 😏