search

boot-clj / boot

Build tooling for Clojure.
https://boot-clj.github.io/
Eclipse Public License 1.0
1.75k stars 181 forks source link

Migration plans for nREPL 0.4 #695

Closed bbatsov closed 6 years ago

bbatsov commented 6 years ago

That's basically a follow up of nrepl/nREPL#1 and was also discussed in nrepl/nREPL#4.

TL;DR; - In verions 0.4 of the "new" nREPL the namespaces will be changed from clojure.tools.nrepl.* to nrepl.*.

As this is a different artifact technically speaking(nrepl/nrepl instead of clojure.tools/nrepl) I think the best migration path for Boot would be to just start depending on both projects and have two tasks for the two nREPLs until we can drop the old version (e.g. boot repl and boot nrepl). The second task can just start a headless server until reply adds support for nrepl/nrepl.

How does this sound?

arichiardi commented 6 years ago

It sounds like a good approach for me.

alandipert commented 6 years ago

I like the idea of adding a new nrepl task :+1:

bbatsov commented 6 years ago

@alandipert I'm not sure if that makes sense any more, as pretty much all of the essential middleware got updated to support nREPL 0.4 while this and #703 stayed open. Seems to me at this point it would just be simpler to directly switch to 0.4 (and that's also what lein did already - it switch to nREPL 0.4 in master).

If you insist on a boot nrepl we can make this happen, though.