search

boot-clj / boot

Build tooling for Clojure.
https://boot-clj.github.io/
Eclipse Public License 1.0
1.75k stars 179 forks source link

Update nREPL to 0.4.4 #703

Closed bbatsov closed 5 years ago

bbatsov commented 6 years ago

As no one really commented on #695 I've decided to try an alternative approach to get some conversation going. Here's my preferred (quick) solution to the migration to the new nREPL. I know this is probably less than ideal, but it's a one time deal, and I'd really appreciate your support as I rather be dealing with nREPL improvements than with migration paths.

nREPL was recently moved out of clojure-contrib and its development continued under a dedicated org (https://github.com/nrepl). The new project is (and will remain to be) completely backwards compatible on the nREPL API level, but the namespace had to be changed.

This fixes #695.

alandipert commented 6 years ago

Thanks @bbatsov, if this is a backward compatible change I can't see any reason not to do it.

alandipert commented 6 years ago

Oh, this could use a CHANGELOG.md entry though. Thanks in advance for adding one that summarizes the change.

arichiardi commented 6 years ago

Just for future reference, this is not really backward compatible, see: https://github.com/nrepl/nREPL#status

However the tooling goal would be to move towards it we could bump boot's major and advertise the change way in advance. In the meantime folks (like myself) can try things out with all the master code bases (many involved) and confirm everything works.

bbatsov commented 6 years ago

Thanks @bbatsov, if this is a backward compatible change I can't see any reason not to do it.

The protocol is completely the same, but the project has a new namespace, which means that middleware will need small tweaks to work with it. That being said - I'm the direct author/maintainer of almost all popular nREPL middleware and I do plan to switch them to target the new nREPL anyways. :-)

Oh, this could use a CHANGELOG.md entry though. Thanks in advance for adding one that summarizes the change.

Of course. I'll add this in a bit.

bbatsov commented 6 years ago

Changelog entry added.

bbatsov commented 5 years ago

PR updated for nREPL 0.4.3.

bbatsov commented 5 years ago

The build failure is unrelated, btw.

@alandipert Can you tell me if you want us to move forward with this or not? I've invested a tremendous amount of time already coordinating the nREPL upgrade across all related projects and that's the final missing piece. I'd be extremely happy if we can just wrap this up and I can focus on actually improving the server and its middleware. :-)

bbatsov commented 5 years ago

Thanks!