search

boot2docker / boot2docker-cli

boot2docker management utility
Apache License 2.0
339 stars 95 forks source link

Don't mix unset and exports, and cater for spaces in the cert path #351

Closed SvenDowideit closed 9 years ago

SvenDowideit commented 9 years ago

Signed-off-by: Sven Dowideit SvenDowideit@home.org.au

I've copied the docker-machine code, and then escape the spaces.

Closes: https://github.com/boot2docker/boot2docker/issues/716 https://github.com/boot2docker/boot2docker/issues/715

databus23 commented 9 years ago

Another env var was just introduced with #345. Also this one is not always present and can be either no_proxy or NO_PROXY. So I think they old way of doing it dynamic needs to stay.

tianon commented 9 years ago

If we suggest that people use eval $(b2d shellinit), this problem goes away, doesn't it?

SvenDowideit commented 9 years ago

no? the issue lists a number of problems with the code currently.

SvenDowideit commented 9 years ago

@databus23 cool - I'll code it in too - presumably machine has added it to their code?

tianon commented 9 years ago

What I'm saying is that using eval $(...) instead of just $(...) would fix https://github.com/boot2docker/boot2docker/issues/716.

tianon commented 9 years ago

As was mentioned in https://github.com/boot2docker/boot2docker/issues/716#issuecomment-72019148 :+1:

tianon commented 9 years ago

What I'm trying to say is that we should do this, yes, but we should also update our documentation to include eval appropriately.

SvenDowideit commented 9 years ago

@tianon oh. ic - is that what you didn't say :p

SvenDowideit commented 9 years ago

replaced by #361