remove /usr/local/bin/docker only if this are a file, if link don't remove

boot2docker / osx-installer

Docker installer for Mac OS X

Apache License 2.0

1.25k stars 258 forks source link

remove /usr/local/bin/docker only if this are a file, if link don't remove #135

Closed vsth closed 6 years ago

vsth commented 7 years ago

Hi, I have installed Docker for Mac https://docs.docker.com/engine/installation/mac/ With that we have lrwxr-xr-x 1 user staff 66 Nov 12 16:21 /usr/local/bin/docker -> /Users/thomas/Library/Group Containers/group.com.docker/bin/docker installed. I think boot2docker should remove /usr/local/bin/docker only if this is not a link.

vsth commented 7 years ago

https://github.com/boot2docker/osx-installer/pull/136

yosifkit commented 7 years ago

"Docker for Mac" does not use this installer. This project was deprecated with https://github.com/boot2docker/osx-installer/pull/123. You may want to open an issue on their repo: https://github.com/docker/for-mac.

vsth commented 7 years ago

Sure, but this installer removes the /usr/local/bin/docker from other docker implementations. I mean for me this issue are solved.

tianon commented 6 years ago

Sorry, this repository is long-since deprecated in favor of Docker Toolbox (whose usage is now also discouraged in favor of Docker for Windows and Docker for Mac).