search

boot2docker / osx-installer

Docker installer for Mac OS X
Apache License 2.0
1.25k stars 258 forks source link

boot2docker.app does not work with all shells #26

Closed davidcelis closed 10 years ago

davidcelis commented 10 years ago

I'm a fish-shell user, which boot2docker.app is not playing nicely with. It opens a new Terminal window and tries to run a bunch of POSIX syntax stuff, and Fish is purposefully not POSIX compliant. Is it possible to make sure that boot2docker.app opens Terminal.app into a bash shell? I'd submit this as a PR myself, but I see only raw files and no scripts that are actually editable.

geddski commented 10 years ago

&& for one is ;and in fish. I had to set my terminal to use /bin/bash (and leave iTerm2 set to use fish) in order for this to run.

SvenDowideit commented 10 years ago

see #28

clemens-tolboom commented 10 years ago

You can edit the installed file yourself with

$ open -a AppleScript\ Editor.app /Applications/boot2docker.app/Contents/Resources/Scripts/main.scpt
davidcelis commented 10 years ago

Looks like this was fixed in #31 and can be closed. I tested it out and it works, though it's a bit weird that it leaves that window in what might not be the default shell for people (i.e. my default shell is fish and that window leaves me in bash). Technically it could be fixed by just adding a do script "exit" in newWindow at the end, but that would defeat the purpose of exporting DOCKER_HOST for people :wink:

clemens-tolboom commented 10 years ago

@davidcelis it is fixed but now you know how to edit its files :p

firemanphil commented 10 years ago

Yeah agreed, it's a bit odd. Maybe it should't dump the user out to a terminal window anyway, it's a little confusing first time around.