search

boot2docker / osx-installer

Docker installer for Mac OS X
Apache License 2.0
1.25k stars 258 forks source link

Offer an option to run under iTerm if installed #50

Closed artiom closed 10 years ago

artiom commented 10 years ago

Offers an option to run boot2docker under iTerm if installed, falls back to Terminal if not.

boot2docker/boot2docker#414

artiom commented 10 years ago

Is there something that I should change? Or take a different approach?

SvenDowideit commented 10 years ago

@artiom i've finally gotten around to testing this, and I really wonder if popping up a the chooser dialog every run is a good thing.

i don't know what the right way to help a user configure / unconfigure this is - is there something simple, like a

artiom commented 10 years ago

@SvenDowideit I think your last sentence was cut short. I agree that displaying dialog is not the best solution, maybe saving preference to ~/.osx-installer file?

SvenDowideit commented 10 years ago

would you like to ammend the PR to save the user choice to ~/.boot2docker/terminal_choice or something similar? (and then some info to tell the user how to unset it)

artiom commented 10 years ago

I will update my PR

artiom commented 10 years ago

@SvenDowideit update PR with preference file. I added an echo as a last command with explanation text, however I'm not sure this is the correct place for it. Let me know what do you think.