search

bootboxjs / bootbox

Wrappers for JavaScript alert(), confirm() and other flexible dialogs using Twitter's bootstrap framework
http://bootboxjs.com
Other
5.04k stars 1.04k forks source link

Any plans for BS5 support? #777

Closed dleffler closed 1 year ago

dleffler commented 3 years ago

Since Bootstrap v5 is about to go beta (last breaking changes implemented), are there plan to make bootbox BS5 friendly?

tiesont commented 2 years ago

@csiqueirasilva That's a known problem with using Bootstrap 5 and Bootbox 5. If you need Bootstrap 5 support, the only option at the moment is the WIP branch: https://github.com/makeusabrew/bootbox/tree/v6-wip

csiqueirasilva commented 2 years ago

Indeed i'm using the v6 WIP branch. Even double checked that I was using it and it says here on the starting doc comment: bootbox.js 6.0.0-wip.

Got it here: https://github.com/makeusabrew/bootbox/blob/v6-wip/dist/bootbox.all.min.js

tarlepp commented 2 years ago

For anyone still following this issue, I'm considering pushing my v6/BS5 branch to master. I'd appreciate any effort anyone can make to try out the https://github.com/makeusabrew/bootbox/tree/v6-wip branch before I do that.

@tarlepp Any objections to me doing this at the end of September (or possibly sooner) if no one finds anything?

Sorry for late reply - let me say it has been kind of nightmare at work after my summer vacation...

And no I don't have any objections for your plan - if that helps people it's just great - if that causes some issues, then community should raise an issue or PR to fix those.

tiesont commented 2 years ago

Indeed i'm using the v6 WIP branch. Even double checked that I was using it and it says here on the starting doc comment: bootbox.js 6.0.0-wip. Got it here: https://github.com/makeusabrew/bootbox/blob/v6-wip/dist/bootbox.all.min.js

I've used my WIP branch against both a Bootstrap 4.6 and a Bootstrap 5 project, and I don't see what you're describing. I'd need to see a reproducible error, in a new issue.

csiqueirasilva commented 2 years ago

Indeed i'm using the v6 WIP branch. Even double checked that I was using it and it says here on the starting doc comment: bootbox.js 6.0.0-wip. Got it here: https://github.com/makeusabrew/bootbox/blob/v6-wip/dist/bootbox.all.min.js

I've used my WIP branch against both a Bootstrap 4.6 and a Bootstrap 5 project, and I don't see what you're describing. I'd need to see a reproducible error, in a new issue.

Reproduced in codepen and opened issue #817

tiesont commented 2 years ago

@csiqueirasilva Thank you for the effort. I've responded to your issue.

tiesont commented 2 years ago

Baring any significant issues being found, I'll be pushing Bootbox 6 sometime this upcoming week. This will add Bootstrap 5 compatibility, although I'm punting on removing jQuery at this point. Will revisit that topic when I have more time.

I'll also be updating the docs again. I've rebuilt the docs using a mostly stock Bootstrap theme and switched to a Jekyll-built system. You can see the upcoming version here, which also demonstrates some of the tweaks you can expect to the UI: https://tiesont.github.io/bootboxdocs/

tiesont commented 1 year ago

Closed in #820