search

bootboxjs / bootbox

Wrappers for JavaScript alert(), confirm() and other flexible dialogs using Twitter's bootstrap framework
http://bootboxjs.com
Other
5.04k stars 1.04k forks source link

Possibility of using Github actions instead of Travis CI #810

Closed jstark518 closed 2 years ago

jstark518 commented 2 years ago

Replace Travis CI integration with a Github Action.

This has the benefit of simplifying automated testing and should allow Github to generate the minified files and zipped archives.

jstark518 commented 2 years ago

@tiesont I worked on it in a fork and getting Actions to run the test is pretty easy and should work without any changes to this repo at all. However getting Actions to commit the dist folder is a bit harder and would require a change in the repo's settings.

image Actions normally only have read permissions, it would also need write permissions to be able to commit the changes it makes.

https://github.com/jstark518/bootbox

tiesont commented 2 years ago

@jstark518 That's good to hear, although that second point means we can't setup an automated deploy/release on this repo. If we can at least get something setup to show that the tests pass, that would still be useful, even if that's all it can really do.

Thanks for looking into this. I do very much appreciate the effort.