search

bootboxjs / bootbox

Wrappers for JavaScript alert(), confirm() and other flexible dialogs using Twitter's bootstrap framework
http://bootboxjs.com
Other
5.04k stars 1.04k forks source link

Title and Close X #816

Closed Cytotoxic closed 2 years ago

Cytotoxic commented 2 years ago

The title is right aligned and the close X floats on the left side of the title length. BS 5.1.3 bootbox

tiesont commented 2 years ago

This has been covered before - this is what you're going to see using Bootbox 5 with Bootstrap 5.

Cytotoxic commented 2 years ago

Sorry I am using 6.0.0-wip

tiesont commented 2 years ago

@Cytotoxic If you want to provide a reproducible example of this using the v6 branch and Bootstrap 5, I'll reopen the issue. I'm using both in a current project and I do not see what your screenshot demonstrates.

Cytotoxic commented 2 years ago

@tiesont You are correct it worked when building out a test it must be a conflict with something else I am running.

tiesont commented 2 years ago

@Cytotoxic Yeah, if you're relying on npm or similar, the v6 branch has not been published anywhere, so it would pull in v5.

Cytotoxic commented 2 years ago

@tiesont I found out what just not why it's building the /h5 tag after the /button tag when it should be building the h5 tag first. But again, not an issue since my bare bones test worked with only necessary files for the test.

Cytotoxic commented 2 years ago

@tiesont Actually there is an issue with the ".min" version here is the test: https://jsfiddle.net/kyr8saxt/1/

It works when I run the unminified version but not with the minified version of 6.0.0-wip