search

bootboxjs / bootbox

Wrappers for JavaScript alert(), confirm() and other flexible dialogs using Twitter's bootstrap framework
http://bootboxjs.com
Other
5.04k stars 1.04k forks source link

Gh pages updates and feedback #834

Closed makeusabrew closed 1 year ago

makeusabrew commented 1 year ago

Submitting a PR more for visibility's sake than anything else 🙂

tiesont commented 1 year ago

@makeusabrew The gh-pages content is the generated output from https://github.com/tiesont/bootboxdocs - what I'd like to do is update the repo to use some version of that (or replace it with something newer, if someone wants to go that route). I also didn't realize, when I pushed it to "production", that the current site pretty much looks like crap on mobile (I really thought I tested that, but guess not).

It also seems like Github really wants us to use a /docs directory in the master/main branch, which would let us use the updated build tooling around site publishing.

Maybe we enable the Discussions tab and start a topic about this?

aadrian commented 1 year ago

Maybe we enable the Discussions tab and start a topic about this?

+1

Formatting of code samples seems broken on most examples on the main site.

tiesont commented 1 year ago

Maybe we enable the Discussions tab and start a topic about this?

+1

Formatting of code samples seems broken on most examples on the main site.

Yeah, I suspect @makeusabrew is using different line endings and whatnot than me. I thought that was accounted for, but I seem to have missed some stuff in my desire/haste to push updates to account for v6.

makeusabrew commented 1 year ago

Sorry folks, I've nerfed my GitHub notification settings due to one or two repositories being way too chatty and now seem to be getting no emails at all. Massive apologies for messing up the examples formatting.

I'm up for enabling discussions and planning a proper way forward for the docs. GH pages definitely looks like the legacy way to do things. On the plus side after a lot of faff the site is finally now served over HTTPS - only a few years late on that one ;)

tarlepp commented 1 year ago

We should also enable auto deletion of merged branches, so that we don't have tons of meaningless branches.