search

bootchk / resynthesizer

Suite of gimp plugins for texture synthesis
GNU General Public License v3.0
1.47k stars 163 forks source link

autogen automake check for 1.12 #10

Closed orbisvicis closed 12 years ago

orbisvicis commented 12 years ago

There needs to be a check for automake version 1.12. However, instead of adding additional entries and possible bug reports every time a new automake version is released, why not instead use:

if [[ AUTOMAKE="$(command -v automake)" && (("$("$AUTOMAKE" --version sed -n 's/automake .*[[:digit:]].\([[:digit:]]\+\).[[:digit:]]$/\1/p')">=6)) ]]; then echo "GOOD"; fi
bootchk commented 12 years ago

I am not knowledgeable enough to confirm your patch.

AFAIK the autogen.sh script included in the repository does check for automake > 1.16.

As I recall, the autogen.sh script in the repository is something I hacked (in an automated way, just globally substituting "resynthesizer", as directed by instructions I read somewhere) from a GIMP plug-in template directory. I don't know whether I need to update the autogen.sh script when and if the GIMP project redefines it.

It is not clear to me which file your patch targets. I am guessing that it targets a file that was generated, so is not appropriate.

Possibly the repository includes build scripts that are generated, and are out of sync with the script they were generated from. For example, did I update autogen.sh and then forget to run it before committing the files it generates to the repository?

Again, thanks.

bootchk commented 12 years ago

Oops, my last post is in error. I looked at autogen.sh and saw "1.16" but it is "1.6". So you are using 1.12 and the script complains that it is not new enough?

So your patch is to autogen.sh ?

In that case, the patch might apply to many GIMP related projects, since I think they might have cloned this autogen.sh script like I did.

I will look at the current autogen.sh script used by the main GIMP project and either update from it or use your patch.

bootchk commented 12 years ago

Thanks again. Your script doesn't set variables like the old script did, so I used another, ugly patch. Since automake is only updated every few years, I will deal with it again then.

orbisvicis commented 12 years ago

Sorry about that. If it makes a difference, a working patch: http://sprunge.us/aCKf