search

bootchk / resynthesizer

Suite of gimp plugins for texture synthesis
GNU General Public License v3.0
1.47k stars 163 forks source link

Fixing Issue #18: automake-1.14 compatibility #19

Closed changlinli closed 10 years ago

changlinli commented 10 years ago

autogen.sh currently doesn't recognize automake-1.14 (or any versions of automake newer than automake-1.13). I've tried to fix this in autogen.sh by both explicitly adding automake-1.14 and just adding automake to the long list of elifs.

changlinli commented 10 years ago

I don't know whether resynthesizer has a testing suite that I could run my commit against, but I tried installing resynthesizer with my changes and it worked for what's worth.

bootchk commented 10 years ago

Thanks. I know it is fragile, but I don't know enough about the shell and gnu build tools to fix it properly.

bootchk commented 10 years ago

Re testing: there is a test script in the Test directory. It reads a set of input images, produces a new image, and compares to a reference image. The test suite won't pass if you compiled threaded, since then the results are non-deterministic (a few random bits will be different) but to a human eye, the results should be the same. Probably not worth testing, unless you are changing platforms, or altering the code. There haven't been any real bugs reported in years (aside from faults in the build system.)

I can't understand why anyone would want to build it themselves rather than find a binary executable.

changlinli commented 10 years ago

Well in my case, the reason why I built it is because Debian Testing doesn't have the resynthesizer (or other GIMP plugins) package due to a problem with some dependency (forgot which one) and the executables on the GIMP plugin registry are 32-bit only. There's also a certain fun in successfully compiling something from source :) (as long as it doesn't happen too often...).

bootchk commented 10 years ago

Thanks. Just so I understand better... are you a Gimp user that uses the Resynthesizer and wants a 64-bit version? And you are a Debian user, who uses the "Testing" branch (which other distributions might call the stable branch: not fully tested but not too crashy?)

I use Ubuntu (a released version) (which I understand is based on Debian.)

There used to be a Debian maintainer for a resynthesizer package. I'm not sure there still is. Are you saying there is such a package in Debian stable, but it has fallen out of the Testing branch for some reason? Would you suggest that I become the Debian maintainer (since if resynthesizer was in Debian, it would probably be in most other distributions such as Ubuntu that are based on Debian) ?