Remove underscore - Githubissues

bootchk / resynthesizer

Suite of gimp plugins for texture synthesis

GNU General Public License v3.0

1.47k stars 163 forks source link

Remove underscore #75

Open DanRiffo opened 4 years ago

DanRiffo commented 4 years ago

https://github.com/bootchk/resynthesizer/blob/adfa25ab0d11ed27ff301cb7db4b144c4c2fa112/PluginScripts/plugin-heal-selection.py#L162

Please remove underscore on "_Heal selection..." GIMP 2.10.18 gets confused by it and doesn't display the script under Filters/Enhance menu because of this. Incorrect line 162: N("_Heal selection..."), Correct: N("Heal selection..."),

SimoneStarace commented 4 years ago

It's strange. On what OS are you using GIMP? I have putted the files inside the plug-ins folder and it still founds it. Have you changed also the permissions on the files?

DanRiffo commented 4 years ago

in order: Running GIMP 2.10.18 under Arch Linux current Tried:

installing gimp-plugin-registry from AUR
installing gimp-plugin-resynthesizer (regular and git) from AUR
installing directly from here and changing permissions (cd /usr/lib/gimp/2.0/plug-ins/ ; chmod +x *.py) no dice, only Heal Transparency was detected by GIMP. Checked files and noticed the weird "_" only at Heal Selection... et voila Oddly enough, render/Texture works fine with the underscore. GIMP being GIMP I guess.

bootchk commented 4 years ago

I will certainly be glad to remove the underscore once I have time to verify it is a problem. It is very strange that it should be a problem.

The underscore just tells the menu system to use Ctl-H (or similar) shortcut key, if that shortcut key is not already used by another plugin. It certainly is not important that the shortcut exists, but on the other hand, it was OK until the latest version of Gimp, and I am unaware that they changed Gimp in this regard.

In the meantime, it is a text file, you can simply edit the file itself and delete the underscore, as a workaround.

DanRiffo commented 4 years ago

exactly right. Let's just let this be here in case someone else needs it ;D