search

bootchk / resynthesizer

Suite of gimp plugins for texture synthesis
GNU General Public License v3.0
1.39k stars 164 forks source link

Use printf instead of echo -n in autogen.sh #84

Closed ryandesign closed 3 years ago

ryandesign commented 3 years ago

echo -n is not portable; printf is.

Before this change, here is what running autogen.sh looks like on macOS:

-n checking for autoconf >= 2.54 ...
yes (version 2.69)
-n checking for automake >= 1.6 ...
-n checking for glib-gettextize >= 2.0.0 ...
yes (version 2.58.3)
-n checking for intltool >= 0.17 ...
yes (version 0.51.0)

After this change, it looks the way you intended:

checking for autoconf >= 2.54 ... yes (version 2.69)
checking for automake >= 1.6 ... checking for glib-gettextize >= 2.0.0 ... yes (version 2.58.3)
checking for intltool >= 0.17 ... yes (version 0.51.0)

The missing version information and newline after checking automake is an unrelated issue that I don't intend to address in this PR.

ryandesign commented 3 years ago

The missing version information and newline after checking automake is an unrelated issue that I don't intend to address in this PR.

Addressed in #85.