bootique / bootique-kafka

Provides integration of Kafka client and streams with Bootique
http://bootique.io
Apache License 2.0
4 stars 4 forks source link

"kafkaclient.producer.lingerMs" - rename to "linger" and use Duration type #21

Closed andrus closed 5 years ago

andrus commented 5 years ago

Now that we have decent value types, using an explicit "ms" config property just seems old. Let's rename kafkaclient.producer.lingerMs - to kafkaclient.producer.linger and make it a Duration type.

Also adding the config docs and changing the default for linger from 1 to 0 (as is the Kafka default per docs).

Upgrade Notes

Change all references to kafkaclient.producer.lingerMs in your config to kafkaclient.producer.linger . Note that once you do it, you can use any supported duration format e.g. "1s"

Pay attention to the default change from 1 to 0.