search

bootleg / ret-sync

ret-sync is a set of plugins that helps to synchronize a debugging session (WinDbg/GDB/LLDB/OllyDbg2/x64dbg) with IDA/Ghidra/Binary Ninja disassemblers.
GNU General Public License v3.0
2.04k stars 262 forks source link

ghidra addHighlightBrace has been renamed to addBraceHighlight in master #81

Open alexmaloteaux opened 2 years ago

alexmaloteaux commented 2 years ago

not really an issue atm but more a warning, addHighlightBrace in ghidra master / 10.2 has been rename to addBracehighlight here : https://github.com/NationalSecurityAgency/ghidra/blob/bed44bd55dc88c7c6fab5f158cdb4b9daa087519/Ghidra/Features/Decompiler/src/main/java/ghidra/app/decompiler/component/ClangHighlightController.java#L610

compilation of the plugin against master fails here : https://github.com/bootleg/ret-sync/blob/7602ddd8ebc77f5f14d958e26843944861331b66/ext_ghidra/src/main/java/retsync/LocalColorizerService.java#L302

bootleg commented 2 years ago

Hello Alexandre,

Big thank you for the heads-up here.

The highlighting code in the Ghidra plugin is really shaky right now.

I need to dig more into it but a stable highlighter service would be great, it was missing so far with many classes not exposed. https://github.com/NationalSecurityAgency/ghidra/commit/02ef6109e27d2bf930ab40ab66fa2538ee15afe9

I'll keep the issue open until the 10.2 is released and I update ret-sync code accordingly.

Thanks.

fenugrec commented 1 year ago

Hi, this is preventing a build of ret-sync with gradle-7.6, jdk19, for ghidra 10.2.2 .

Ideas for a workaround ? [edit] - there is, #96