search

bootlin / buildroot-external-st

External Buildroot tree for STMicroelectronics boards configurations
56 stars 28 forks source link

add support for STM32MP157F-DK2 with working OPP #15

Closed 0xDRRB closed 2 years ago

0xDRRB commented 2 years ago

add support for STM32MP157F-DK2 , and new DTS files that get rid of the "cpu cpu0: OPP table can't be empty" message at boot. (STM32MP157A-DK1 and STM32MP157C-DK2 are reported as obsolete in STM32CubeMX now)

samuelpowell commented 2 years ago

@0xDRRB was there a specific change you made to fix the performance point issues (that can be backported to the A/C devices), or is it just that the generated/included dts have the appropriate entries?

0xDRRB commented 2 years ago

@samuelpowell The "stm32mp157f-dk2-mx.dts" file (generated by STM32CubeMX) in this PR includes "stm32mp15xf.dtsi" which itself includes "stm32mp15xd.dtsi" where the correct configuration of the OPP table is.

If you take a look at "stm32mp15xa.dtsi" (included from "stm32mp15xc.dtsi"), you will see that there is only one frequency in the OPP table: 650 Mhz. This is the maximum speed of A/C devices, and the main difference between STM32MP157 A/C and STM32MP157 D/F.

samuelpowell commented 2 years ago

Thanks @0xDRRB, I understand. I also found that I had to enable the 'PLL1 User defined configuration' option in order to use the CubeMX generated files. Without this option there was no PLL1 node in the device tree, and U-boot was unhappy.

kmaincent commented 2 years ago

Hello, thanks for your work. There are few points to be fixed to accept your merge request:

FYI, I am currently working on the v2022.02 version which will have this, and I will probably use what you have already done.

tpetazzoni commented 2 years ago

This has been addressed in the recently published st/2022.02 branch, together with lots of other improvements.