search

bootlin / buildroot-external-st

External Buildroot tree for STMicroelectronics boards configurations
48 stars 25 forks source link

Use a tag for OP-TEE instead of arbitrary commit #4

Closed tpetazzoni closed 2 years ago

kmaincent commented 2 years ago

Need this commit : https://github.com/STMicroelectronics/optee_os/commit/967326c73f80b4c471ceff7e0c9e8735b881ccb5 to avoid build error on Buildroot.

tpetazzoni commented 2 years ago

OK. I am hesitating between keeping this, or using the tag + a patch. Not sure.

kmaincent commented 2 years ago

You prefer to avoid a patch on U-boot but you are ok with a patch on OP-TEE?

tpetazzoni commented 2 years ago

The patch on OP-TEE is upstream: it can be dropped at the next OP-TEE update.

Completely different from the U-Boot patch, which you said yourself would never be accepted upstream.

kmaincent commented 2 years ago

ah ok. Then have you a better idea of which choices do you prefer between keeping this or using the tag + a patch?

tpetazzoni commented 2 years ago

Let's keep the commit as-is for now. We should perhaps document this somewhere, though.