search

bootlin / buildroot-external-st

External Buildroot tree for STMicroelectronics boards configurations
48 stars 26 forks source link

Correct the partition number for rootfs #48

Closed cryptohase closed 7 months ago

cryptohase commented 8 months ago

Updated the partition number of the root filesystem. After introducing the u-boot-env partition in genimage.cfg, the root filesystem could not mount due to an incorrect partition number.

[ 2.373989] b300 15558144 mmcblk0 [ 2.374000] driver: mmcblk [ 2.380859] b301 216 mmcblk0p1 fab2539d-8fb5-47a8-a90f-676544132344 [ 2.380874] [ 2.389826] b302 216 mmcblk0p2 eba4948f-5c0a-4228-abee-ad0259fb7b57 [ 2.389839] [ 2.398790] b303 1558 mmcblk0p3 fae1edb5-642c-41d3-8c85-001b46e68812 [ 2.398803] [ 2.407618] b304 2048 mmcblk0p4 370b6b61-116c-43c6-ac51-ec471e2a5d55 [ 2.407629] [ 2.416595] b305 122880 mmcblk0p5 ddd2d7da-33b7-427b-9d27-e01ad2c6557f [ 2.416609] [ 2.425557] No filesystem could mount root, tried: [ 2.425564] ext3 [ 2.430445] ext2 [ 2.432382] ext4 [ 2.434317] squashfs [ 2.436151] vfat [ 2.438490] msdos [ 2.438810] usb 1-1: new high-speed USB device number 2 using ehci-platform [ 2.440327] ntfs [ 2.449373] [ 2.452740] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(179,4) [ 2.461143] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 6.1.28 #1 [ 2.467022] Hardware name: STM32 (Device Tree Support)

kmaincent commented 7 months ago

Thanks for your change. It is almost ok. We don't like long lines in the commit message. For example, Linux project wants to have it wrapped to 75 characters. It is okay for commit reference or URL in the message but avoid it as much as possible. It is easier to read to have this message wrapping.

Github wrapped my last comment badly. Could you add a carriage return in the second line like that:

A new partition has been added by the commit 69a6b0d ("board/st/stm32mp1/genimage.cfg: Add u-boot environment partition layout") but the rootfs partition in extlinux.conf didn't follow.

kmaincent commented 7 months ago

Thanks for your patch! I have applied it manually.