search

bootphon / phonemizer

Simple text to phones converter for multiple languages
https://bootphon.github.io/phonemizer/
GNU General Public License v3.0
1.19k stars 166 forks source link

Add ignore option to disable language_switch by default #30

Closed ZihanJin closed 4 years ago

mmmaat commented 4 years ago

Hi ZihanJin,

Thanks for the PR! I have few comments/questions.

ZihanJin commented 4 years ago

Oops sorry I was testing how to ignore language switch I thought I modified it in my own repo!

I didn't look into espeak-ng source code, but it frequently misrecognizes Italian/French with English words when I have a code-switching sentence. So I was trying to just skip this function.

On Thu, Dec 5, 2019 at 8:31 PM Mathieu Bernard notifications@github.com wrote:

Hi ZihanJin,

Thanks for the PR! I have few comments/questions.

  • First a simple bug: https://travis-ci.org/bootphon/phonemizer/builds/621088061#L484
  • You are saying there are many language detection mistakes, can you have examples? Is the (.+?) regular expression not generic enough?
  • Your new ignore option is almost identical to keep-flags, right? In that case I would prefer to replace the actual keep-flags by your ignore one, so as to keep the interface as simple as possible. What do you think?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bootphon/phonemizer/pull/30?email_source=notifications&email_token=AMFWVFAYIZOC36F2WB4U5HTQXDYDZA5CNFSM4JVYMZX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGARZFQ#issuecomment-562109590, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMFWVFGRD64EGKAXT7UIWLDQXDYDZANCNFSM4JVYMZXQ .

mmmaat commented 4 years ago

indeed this language switching is related to espeak-ng, not phonemizer! Phonemizer just deals with the language tags: (fr), (en), etc...

ZihanJin commented 4 years ago

Got it! Sorry for the following stupid question: so does it mean when phonemizer didn't have this option, espeak-ng still translates code-switching sentences automatically anyway? Meaning there is no way to skip that unless I make changes in espeak-ng...

Thank you Mathieu!

On Thu, Dec 5, 2019 at 9:01 PM Mathieu Bernard notifications@github.com wrote:

indeed this language switching is related to espeak-ng, not phonemizer! Phonemizer just deals with the language tags: (fr), (en), etc...

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/bootphon/phonemizer/pull/30?email_source=notifications&email_token=AMFWVFGNQM22WOVPVP47ECDQXD3RPA5CNFSM4JVYMZX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGAUGNY#issuecomment-562119479, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMFWVFDRRQ5ESLQSBC6CJCDQXD3RPANCNFSM4JVYMZXQ .

mmmaat commented 4 years ago

yes exactly!