search

bootphon / phonemizer

Simple text to phones converter for multiple languages
https://bootphon.github.io/phonemizer/
GNU General Public License v3.0
1.19k stars 166 forks source link

Save file in utf-8 explicitly for Windows compat #43

Closed boltomli closed 4 years ago

boltomli commented 4 years ago

When dealing with Chinese characters on Chinese version Windows, the file is saved in CP936 that will make the output not usable (shown and read as umlaut, etc.). Save the temp file for espeak backend in utf-8 explicitly to resolve the issue.

codecov[bot] commented 4 years ago

Codecov Report

Merging #43 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          676       676           
=========================================
  Hits           676       676
Impacted Files Coverage Δ
phonemizer/backend/espeak.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e0bd28...9ae6064. Read the comment docs.

mmmaat commented 4 years ago

Thank you!