Closed alongreyber closed 4 years ago
Merging #45 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #45 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 676 676
=========================================
Hits 676 676
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 267960a...46e5641. Read the comment docs.
Great thank you! I'm merging.
When I cloned the repository and ran
docker build -t phonemizer .
I received the following error:This was caused by an outdated version of pytest that comes with installing
python3-pytest
through apt. I fixed this by installingpytest
through pip. After that I had four failing tests:These were caused by the tests looking for
python
executable but onlypython3
is available when installing python via apt. I modified the Dockerfile to create a symlink to thepython
executable rather than modifying the tests themselves.You should be able to confirm that
docker build -t phonemizer .
works with the modified Dockerfile. Let me know if there is a different way you would like me to fix either of these issues!