bootphon / phonemizer

Simple text to phones converter for multiple languages
https://bootphon.github.io/phonemizer/
GNU General Public License v3.0
1.19k stars 166 forks source link

Update logger.py #61

Closed gdoras closed 3 years ago

gdoras commented 3 years ago

import phonemizer causes a call to get_logger() which configures the default logger. This causes duplicated logs if the same logger is used in the project importing Phonemizer. To avoid it, we have to call get_logger('quiet') after importing. It might be easier to name the logger used in Phonemizer (and to set it quiet by default).

codecov[bot] commented 3 years ago

Codecov Report

Merging #61 (04bd80a) into master (1283d99) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          14       14           
  Lines         743      743           
=======================================
  Hits          742      742           
  Misses          1        1           
Impacted Files Coverage Δ
phonemizer/logger.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1283d99...04bd80a. Read the comment docs.

mmmaat commented 3 years ago

Thanks !