bootphon / pygamma-agreement

Gamma Agreement in Python
MIT License
43 stars 8 forks source link

[JOSS] fix continuum figure plot #23

Closed faroit closed 3 years ago

faroit commented 3 years ago

Hi @bootphon this is PR is part of my JOSS review https://github.com/openjournals/joss-reviews/issues/2989

While reading the paper, I realized that the figures for the continuum vs best alignment are identical. I guess you just copied the wrong file twice. I corrected this by using the corresponding file from the docs dir.

hadware commented 3 years ago

Oh my, this is such a ridiculous mistake. Good thing that you noticed it ! Thanks a lot for the PR, merging it right away.