[JOSS] Improve clarity of statement of need section

faroit commented 3 years ago

Hi authors, I went once more through the paper and I have three more comments that would be great if those can be addressed in another iteration:

[x] the introduction reads very well but misses out the technical details of how the gamma-measure actually works. I don't think there would be enough space to include more details on the algorithm but if possible, there could be 1 or 2 sentences added in shortly (and intuitively) to describe the basic idea of the gamma agreement algorithm.
[x] there are already a good amount of references when it comes to the comparison of the measures. I would however welcome one more reference of a well-cited study that is using the gamma agreement measure for their analysis of results.
[x] related to #23, the plots are now fixed but I would welcome a more descriptive figure caption that describes what the continuum and the alignment is showing in plain words.

This issue is part of my JOSS review https://github.com/openjournals/joss-reviews/issues/2989

hadware commented 3 years ago

Thanks for the feedback, i'll update the paper to include your remarks.

hadware commented 3 years ago

I updated the paper to include your suggestions. (point 1 and 2 are in the Statements of needs section, point 3 was added as additional explanations under the respective figures). I hope this made the paper clearer.

faroit commented 3 years ago

@hadware thanks a lot. This greatly improves the readability of the paper. I just made a minor comment on a1ccca1 feel free to close this issue (with our without incorporating my proposal)

hadware commented 3 years ago

Thanks for pickup on those again! :) I corrected these small issues in 22e0a82761404c06b7323bc33dabf45fc2256c40 . I'm closing the issue, don't hesitate on reopening it if you feel that some things are still not quite right.

bootphon / pygamma-agreement

[JOSS] Improve clarity of statement of need section #24