Fixes #15 Remove new line from json parser

bootprint / bootprint-base

Base template for bootprint-module

MIT License

3 stars 1 forks source link

Fixes #15 Remove new line from json parser #16

Closed marc0l92 closed 3 years ago

nknapp commented 6 years ago

I'll have to check why the tests are failing. But it has failed before already. Looks like something else is broken

nknapp commented 6 years ago

Oh, could you add a test here: ,https://github.com/bootprint/bootprint-base/blob/d7cf28bda8dfa5ae95a2c67c2147b3fd43ec85f6/test/helper-spec.js#L100

nknapp commented 6 years ago

I'd like to rebase your branch on the current master to see what the tests are doing with your commit. Is that OK?

marc0l92 commented 6 years ago

Yes, It is ok. I'm not an expert of GIT in general therefore if you think that a rebase can solve the testing issues do it.

I will look at the test that you request me in the weekend.

marc0l92 commented 6 years ago

I'm trying to run the testing scripts (npm test) but I get this errror:

warning: you are using async-hook which is unstable.
....\bootprint-base\node_modules\stack-chain\index.js:10
    throw new Error('Conflicting version of stack-chain found');
    ^

Error: Conflicting version of stack-chain found

Do you know how to solve it? It seems that there is a problem with a dependency.