search

bootsoon / ng-circle-progress

A simple circle progress component created for Angular based on SVG Graphics.
https://bootsoon.github.io/ng-circle-progress/
MIT License
250 stars 85 forks source link

Builds fail in Angular 9. #116

Closed jlbates closed 4 years ago

jlbates commented 4 years ago

There are some breaking changes in Angular 9 for libraries. Per the migration docs for Angular 9:

"ModuleWithProviders type without a generic Some Angular libraries, such as @angular/router and @ngrx/store, implement APIs that return a type called ModuleWithProviders (typically via a method named forRoot()). This type represents an NgModule along with additional providers. Angular version 9 deprecates use of ModuleWithProviders without an explicitly generic type, where the generic type refers to the type of the NgModule. In a future version of Angular, the generic will no longer be optional.

If you're using the CLI, ng update should migrate your code automatically. If you're not using the CLI, you can add any missing generic types to your application manually."

https://angular.io/guide/deprecations#modulewithproviders-type-without-a-generic

Screen Shot 2020-03-19 at 11 36 16 AM
jlbates commented 4 years ago

I think this change will fix the problem. https://github.com/bootsoon/ng-circle-progress/pull/117

ocsi94 commented 4 years ago

+1 error confirmed

mannyorozco commented 4 years ago

+1

Can someone verify and merge the open PR please.

bootsoon commented 4 years ago

Sorry for late merging.